-
Notifications
You must be signed in to change notification settings - Fork 6
feat(react-native): add Windows support for React Native quickstart app #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
teodorciuraru
wants to merge
9
commits into
main
Choose a base branch
from
teodor/sdks-1252-featrn-bare-cli-quickstart-app-windows-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(react-native): add Windows support for React Native quickstart app #137
teodorciuraru
wants to merge
9
commits into
main
from
teodor/sdks-1252-featrn-bare-cli-quickstart-app-windows-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add full Windows project structure via React Native Windows - Implement Ditto singleton pattern to handle Windows component lifecycle - Replace native Modal with custom overlay for proper Windows rendering - Add NuGet.config for Windows package resolution - Update README with Windows prerequisites and setup instructions - Revert Ditto SDK from local path to stable version 4.12.0 - Remove package-lock.json in favor of yarn.lock Windows-specific improvements: - Prevents multiple Ditto instances during component remounting - Modal renders correctly within window bounds - Handles Fast Refresh gracefully with singleton pattern 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add Windows build job to react-native-ci.yml workflow - Configure Windows Server 2022 runner with MSBuild and Visual Studio - Add NuGet package caching for faster builds - Update build:windows script to use --no-deploy --no-launch flags for CI - Fix Ditto SDK dependency to use published version 4.12.0 instead of local file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Replace local file reference with published version ^4.12.0 - Update yarn.lock to match package.json dependencies - Fixes CI lint step that requires frozen lockfile 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add .claude settings for local development - Keep local Ditto SDK path for testing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Replace UWP template with cpp-app template for Win32 desktop - Configure for React Native 0.79.1 with React Native Windows 0.79.3 - Enable new architecture (Fabric/TurboModules) support - Add proper DLL packaging configuration - Clean up build artifacts and update .gitignore - Use local Ditto SDK package with Windows support 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
3308535 to
a149aed
Compare
chore: fix lint chore: `rm package-lock.json` Keeps `yarn` bias for the moment. chore: update package.json
4a27018 to
bec08ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan
🤖 Generated with Claude Code